Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bom runtime error #127

Closed
mdeicas opened this issue Jun 24, 2022 · 2 comments · Fixed by #128
Closed

bom runtime error #127

mdeicas opened this issue Jun 24, 2022 · 2 comments · Fixed by #128
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@mdeicas
Copy link

mdeicas commented Jun 24, 2022 •
edited

What happened:

Running bom generate on the repository https://github.com/lumjjb/sample-golang-prov fails with a runtime error using the latest commit of bom.

The error occurred both when running in a github action and when running locally. Link to the github action logs: https://github.com/lumjjb/sample-golang-prov/runs/7026978132?check_suite_focus=true#:~:text=level%3Dinfo%20msg%3D%22Got,with%20exit%20code%202

How to reproduce it (as minimally and precisely as possible):

Clone the sample-golang-prov repository and run bom generate -n "http://www.example.com/binary.spdx" -o "binary.spdx" ..

Anything else we need to know?:

The error does not occur when using bom at commit 5cfc466ecf53.

Environment:

  • OS: Ubuntu 20.04.4 (for the github runner)
@mdeicas mdeicas added kind/bug Categorizes issue or PR as related to a bug. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jun 24, 2022
@sbs2001
Copy link
Member

sbs2001 commented Jun 26, 2022

Just triaged this. The error is present since c1f1fa3 . The bug might be in the latest https://github.com/google/licenseclassifier .

@saschagrunert
Copy link
Member

A fix is already WIP in google/licenseclassifier#44

For now I agree that we should revert and will propose that tomorrow.

saschagrunert added a commit to saschagrunert/bom that referenced this issue Jun 27, 2022
@saschagrunert
Revert "Bump github.com/google/licenseclassifier/v2 to v2.0.0-pre5"
096fbcc 
This reverts commit c1f1fa3 because of
a runtime panic possibly fixed in
google/licenseclassifier#44.

Fixes to kubernetes-sigs#127

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert added a commit to saschagrunert/bom that referenced this issue Jun 27, 2022
@saschagrunert
Revert "Bump github.com/google/licenseclassifier/v2 to v2.0.0-pre5"
83dc349 
This reverts commit c1f1fa3 because of
a runtime panic possibly fixed in
google/licenseclassifier#44.

Fixes kubernetes-sigs#127

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert mentioned this issue Jun 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Bump github.com/google/licenseclassifier/v2 to v2.0.0-pre5" saschagrunert/bom
3 participants
@saschagrunert @sbs2001 @mdeicas