Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Bump github.com/google/licenseclassifier/v2 to v2.0.0-pre5" #128

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Revert "Bump github.com/google/licenseclassifier/v2 to v2.0.0-pre5" #128

merged 1 commit into from
Jun 27, 2022

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

This reverts commit c1f1fa3 because of a runtime panic possibly fixed in google/licenseclassifier#44.

Which issue(s) this PR fixes:

Fixes #127

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Reverted licenseclassifier update because it includes a runtime panic regression.

@saschagrunert
Revert "Bump github.com/google/licenseclassifier/v2 to v2.0.0-pre5"
83dc349 
This reverts commit c1f1fa3 because of
a runtime panic possibly fixed in
google/licenseclassifier#44.

Fixes kubernetes-sigs#127

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 27, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 27, 2022
cpanato
cpanato approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgmt

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2022
@k8s-ci-robot k8s-ci-robot merged commit d8aa4cf into kubernetes-sigs:main Jun 27, 2022
@saschagrunert saschagrunert deleted the lc-revert branch June 27, 2022 07:45
@puerco
Copy link
Member

puerco commented Jun 27, 2022

Yay thanks for fixing this Sascha. I was working on the same patch last Saturday!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bom runtime error
4 participants
@saschagrunert @k8s-ci-robot @puerco @cpanato