Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support close/destruct for modifiers #237

Closed
hueich opened this issue Apr 15, 2018 · 2 comments
Closed

Support close/destruct for modifiers #237

hueich opened this issue Apr 15, 2018 · 2 comments

Comments

@hueich
Copy link
Collaborator

hueich commented Apr 15, 2018

This is useful if a modifier needs to release resources before being replaced and garbage collected.
@hueich
Copy link
Collaborator Author

hueich commented Apr 15, 2018

Alternatively, modifiers that need to clean up can do so themselves using a finalizer.

@admtnnr
Copy link
Contributor

admtnnr commented May 26, 2018

I think some of the modifiers that have resources to be released already support io.Closer. It needs to be hooked into the JSON API though. Regarding finalizers, see Tragedy of Finalizers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@admtnnr @bramhaghosh @hueich