Unsetting GCS Bucket paths by default #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
priyanka-ganesha
commented
Jun 13, 2023
•
priyanka-ganesha
commented
- Unset GCS Bucket paths in base.yml file and additional checks to make sure it is not empty before training
- Removed references to setting dcn parallelism value in README
- Changed hardcoded reference to dataset_path to use config value
- Edited multihost_dataloading_test.py to have gcs bucket params
gobbleturk
reviewed
Jun 13, 2023
MaxText/pyconfig.py
Outdated
| @@ -87,6 +87,8 @@ def user_init(raw_keys): | |||
| run_name = raw_keys["run_name"] | |||
| assert run_name, "Erroring out, need a real run_name" | |||
| base_output_directory = raw_keys["base_output_directory"] | |||
| assert base_output_directory, "Erroring out, need a real base_output_directory" | |||
| assert raw_keys['dataset_path'], "Erroring out, need a real dataset_path" | |||
There was a problem hiding this comment.
I think it would be nice to also include a link to the readme section for dowloading the dataset here, something like "Erroring out, need a real dataset_path. See instructions for dowloading the c4 dataset here: https://github.com/google/maxtext/blob/main/README.md#getting-started-download-dataset-and-configure."
gobbleturk
approved these changes
Jun 13, 2023
A9isha
pushed a commit
that referenced
this pull request
Apr 11, 2024
* added remaining nightly pax tests * fix cron scheduling * added test dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.