Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about left right eye landmarks question #1909

Closed
lilinxiong opened this issue Apr 20, 2021 · 10 comments
Closed

about left right eye landmarks question #1909

lilinxiong opened this issue Apr 20, 2021 · 10 comments
Assignees
Labels
legacy:face mesh Issues related to Face Mesh legacy:iris Issues related to Iris platform:c++ Issues specific to C++ framework in mediapipe type:research Model specific questions

Comments

@lilinxiong
Copy link

In all of the landmark connection vector found it FaceMesh_Map.jpg and Contour keypoints. The landmark for the left eye is: left eyes:
image. The landmark for the right eye is: right eyes:
image

But in iris_tracking_gpu.pbtxt. define left eye boundary is (in L84-L96):
image

define right eye boundary is (in L98-L110):
image

In other words, the landmarks in pbtxt and the left and right eye landmarks defined by keypoints are inconsistent. Where is wrong?

@sgowroji sgowroji self-assigned this Apr 20, 2021
@sgowroji sgowroji added platform:c++ Issues specific to C++ framework in mediapipe legacy:face mesh Issues related to Face Mesh legacy:iris Issues related to Iris stat:awaiting googler Waiting for Google Engineer's Response type:research Model specific questions labels Apr 20, 2021
@sgowroji sgowroji assigned gkarpiak and unassigned sgowroji Apr 20, 2021
@lilinxiong lilinxiong changed the title about left right eye landmakrs question about left right eye landmarks question Apr 21, 2021
@04633435
Copy link

Yes, I also noticed this inconsistency when I was trying to change the range of the eye_boundary_landmarks. Did you find the correct landmarks_indices mapping yet?

@lilinxiong
Copy link
Author

@04633435 I think Contour keypoints is right, because it matches the mirror image we perceive. So currently in the graph, I adjust it according to it. I haven't waited for the official reply yet, I'm still waiting for the official explanation.

@04633435
Copy link

04633435 commented May 1, 2021

@04633435 I think Contour keypoints is right, because it matches the mirror image we perceive. So currently in the graph, I adjust it according to it. I haven't waited for the official reply yet, I'm still waiting for the official explanation.

Thank you for your reply!
I just look through the Contour keypoints, but there are only 229 points, half of the vertices excluding the iris landmarks. Seems like there are some points missing. Do you have any clue?

@lilinxiong
Copy link
Author

@04633435 Face Mesh has a total of 468 points. iris is an extra 10 points(left 5, right 5). Not included in FaceMesh.
In iris_tracking_gpu.pbtxt ConcatenateNormalizedLandmarkListCalculator code can be found.
Note: left iris landmarks and right iris landmarks the order is different, you have to distinguish it yourself. I made changes in my app, so this part can’t be shared with you.

@04633435
Copy link

04633435 commented May 4, 2021

Hi, @lilinxiong, I solved my problem. And for the problem you mentioned above, in L84-L96, it selects out the inner corner and outer corner landmarks of the left eye, and within the subgraph iris_landmark_landmarks_to_roi.pbtxt of the iris_landmark module, these two landmarks are used to create a square boundary around the left eye area. So in L84-L96, there are only landmark 33 and 133, not the whole left eye contours landmarks.

@lilinxiong
Copy link
Author

@04633435 I don’t think we are talking about the same issue.

Face Mesh has a total of 468 points. iris is an extra 10 points(left 5, right 5). ........

My answer here is that the iris coordinates are added to the content related to FaceMesh landmark.
Including the order of iris coordinates and the position added to FaceMesh.

And for the problem you mentioned above, in L84-L96, it selects out the inner corner and outer corner landmarks of the left eye.....

As for what you are answering now, I think you only need to exchange the subscript values of left and right in the original pbtxt.
The original intent of this issue is that the left and right in pbtxt are written inversely, so even after swapping left and right, the result is still the opposite. You can verify it yourself.
I'm not sure, whether you know what I want to express, but the final conclusion is: even after you swap left and right, their final value is unchanged, just changing here will not take effect. Other places need to be changed.

@kuaashish kuaashish assigned kuaashish and unassigned gkarpiak Apr 19, 2023
@kuaashish kuaashish removed the stat:awaiting googler Waiting for Google Engineer's Response label Apr 19, 2023
@kuaashish
Copy link
Collaborator

Hello @lilinxiong,
We are upgrading the MediaPipe Legacy Solutions to new MediaPipe solutions However, the libraries, documentation, and source code for all the MediaPipe Legacy Solutions will continue to be available in our GitHub repository and through library distribution services, such as Maven and NPM.

You can continue to use those legacy solutions in your applications if you choose. Though, we would request you to check new MediaPipe solutions which can help you more easily build and customize ML solutions for your applications. These new solutions will provide a superset of capabilities available in the legacy solutions.

@kuaashish kuaashish added the stat:awaiting response Waiting for user response label Apr 19, 2023
@google-ml-butler
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you.

@github-actions
Copy link

github-actions bot commented May 4, 2023

This issue has been marked stale because it has no recent activity since 7 days. It will be closed if no further activity occurs. Thank you.

@github-actions github-actions bot added the stale label May 4, 2023
@github-actions
Copy link

This issue was closed due to lack of activity after being marked stale for past 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy:face mesh Issues related to Face Mesh legacy:iris Issues related to Iris platform:c++ Issues specific to C++ framework in mediapipe type:research Model specific questions
Projects
None yet
Development

No branches or pull requests

5 participants