Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggest: improve path management in gui/about_dialog/about_dialog.cc #35

Closed
GoogleCodeExporter opened this issue Apr 22, 2015 · 1 comment

Comments

@GoogleCodeExporter
Copy link

version: mozc-0.13.464.102
target file: gui/about_dialog/about_dialog.cc
category: absolute path
OS: FreeBSD 9-CURRENT / 8.1-RELEASE
CC: gcc 4.2.1 (FreeBSD default compiler)


'new QImage(":/product_logo.png")' looks depending on path management
of Qt. Please consider another way of path management. OSes prefer to
use their default icon pathes.

Original issue reported on code.google.com by daichig...@gmail.com on 20 Sep 2010 at 3:30

@GoogleCodeExporter
Copy link
Author

Starting with r61, we have "product_icon_32bpp-128.png" at the following 
location.
http://code.google.com/p/mozc/source/browse/trunk/src/data/images/product_icon_3
2bpp-128.png

This file will be embedded into the mozc_tool and finally pointed from the 
about dialog by 'new QImage(":/product_logo.png")' as you found.
See
http://code.google.com/p/mozc/source/browse/trunk/src/gui/about_dialog/about_dia
log.qrc
about how this works.

If you want to use any different product logo, please replace
  src/data/images/product_icon_32bpp-128.png
before you start the build.

I hope this helps you.

Original comment by yukawa@google.com on 17 Aug 2011 at 2:11

  • Changed state: WontFix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant