Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application crashes when you start composing text on Windows #712

Closed
yukawa opened this issue Apr 10, 2023 · 0 comments
Closed

Application crashes when you start composing text on Windows #712

yukawa opened this issue Apr 10, 2023 · 0 comments

Comments

@yukawa
Copy link
Collaborator

yukawa commented Apr 10, 2023

Description
There is a null pointer access issue in b861ff2, which ends up crashing application immediately after you start composing text.

Steps to reproduce
Steps to reproduce the behavior:

  1. Build b861ff2 and install it.
  2. Open notepad.exe
  3. Enable Mozc then start typing anything.

Expected behavior
No application crash.

Actual behavior
It's crashing here.

if (SUCCEEDED(TipCompositionUtil::GetComposition(context, write_cookie)
.As(&composition))) {

When TipCompositionUtil::GetComposition(context, write_cookie) returns nullptr, subsequent .As(&composition) ends up crashing.

Version or commit-id
b861ff2

Environment

  • OS: Windows 11

Additional Information
The fix is on the way. We just need to check the return value, as it used to be.
b861ff2#diff-1a5aa2b35b0e0b109860116f0280b9e3b641f0225f8304c7a3fd70e48a9382c9L454-R456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant