Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Expose a logger in pipeline/How do you take action on ErrDropped #42

Open
RugTumpington opened this issue Mar 11, 2020 · 0 comments
Open

Comments

@RugTumpington
Copy link

p.ProcessReports(ctx, w, r)

This issue is comprised of 2 points:

  • Consider exposing a logger interface to log errors within the pipeline class
  • How can we catch/take action on ErrDropped, it doesn't seem to be bubbled up anywhere outside the class. ServeHTTP method calls it without looking for if there was an error and to my knowledge this doesn't get bubbled up to the HTTP server class (which does expose a logging interface)

I'm the first to admit i'm not the most advanced golang user, so let me know if i'm missing some implimentation detail that obviates the issue. I plan to impliment this at relatively large scale and knowing when we start dropping reports is going to be very valuable to log to our elastic stack.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant