Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RoaringBitmaps for indexing in kvschema #9

Open
burdiyan opened this issue Sep 23, 2020 · 1 comment
Open

Use RoaringBitmaps for indexing in kvschema #9

burdiyan opened this issue Sep 23, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@burdiyan
Copy link

I was really glad to see that I'm not the only one thinking about a nicer abstraction layer for key-value stores like Badger. The package kvschema looks really nice! One thing I'd like to suggest is to use roaring bitmaps for indexing instead of storing uint64 as byte slices.

Would you accept a patch for this, or I better create my own code generator in a similar vein for my own needs?

@jtacoma
Copy link
Member

jtacoma commented Oct 5, 2020

Alexandr, I'd be happy to get a pull request! I hadn't heard for roaring bitmaps before, it looks like a good fit.

We're very pre-1.0 here so don't worry too much about backward-incompatible changes: if there are any, I'll just increment the minor version number.

FYI, I'm not sure I'll be using kvschema in Note Maps despite all the time I put into it. I still like the idea, and even the implementation, but I'm looking at higher-level abstractions these days. It's all still kind of speculative, we'll see what happens.

@jtacoma jtacoma added the enhancement New feature or request label Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants