Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support uniqueMember to identify members of groups from rfc2307bis specification #46

Closed
tomgreen66 opened this issue Jul 15, 2015 · 1 comment

Comments

@tomgreen66
Copy link
Contributor

We use uniqueMember attribute to identify group membership and was an alternate (maybe earlier) method in the draft rfc2307bis specification (the member attribute is already supported). It seems the rfc2307bis is now an expired specification.

I had originally made the changes before I saw the new support for the other rfc2307bis member attribute and had approached it slightly differently. I wanted to query the DN for each uniqueMember in a group to get the uid, rather than assume the cn and uid are the same. This is performed in a new function called PostProcess. For example my first attempt at merging my old code to the new version in commit 8b4cc22 and is untested currently (but the previous version worked fine so the idea works).

We may be able to just use the current member method (and just change it to also support uniqueMember) but comments welcome whether my approach has any merit where uid and cn do not have to be identical.

@jaqx0r
Copy link
Contributor

jaqx0r commented Jul 15, 2015

I dont remember how 2307bis works, but even though it's expired, people use it so it's worth supporting. Sounds like a reasonable idea, if the current default is preserved, and you add tests. How about posting a PR and we can look at the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants