using fullName where gecos and cn don't exist

[jaqx0r]

Original issue 7 created by jaqx0r on 2008-04-18T13:35:38.000Z:

Here at Cardiff University we have a Novell e-directory system where
LDAP/posixAccount functionality was added late. This means the directory
structure is a bit idiosynchratic.

Anyway to cut to the chase: account entries lack gecos or cn. To get around
this I edited ldapsource to use fullName if cn or gecos were not found.

---

diff -uNr nsscache-0.7.3.dist/nss_cache/sources/ldapsource.py
nsscache-0.7.3/nss_cache/sources/ldapsource.py
--- nsscache-0.7.3.dist/nss_cache/sources/ldapsource.py 2008-04-09
05:46:33.000000000 +0100
+++ nsscache-0.7.3/nss_cache/sources/ldapsource.py 2008-04-18
14:32:32.000000000 +0100
@@ -373,7 +373,7 @@
def init(self):
super(PasswdUpdateGetter, self).init()
self.attrs = ['uid', 'uidNumber', 'gidNumber', 'gecos', 'cn',

•              'homeDirectory', 'loginShell']
  

•              'homeDirectory', 'loginShell', 'fullName']
  

  self.essential_fields = ['uid', 'uidNumber', 'gidNumber', 'homeDirectory']

  def CreateMap(self):
  @@ -389,7 +389,10 @@
  pw.gecos = obj['gecos'][0]
  elif 'cn' in obj:
  pw.gecos = obj['cn'][0]

• elif 'fullName' in obj:

•  pw.gecos = obj['fullName'][0]
  

  else:
  raise ValueError('Neither gecos nor cn found')

  pw.name = obj['uid'][0]

---

in the short term this works but is a bit inelegant. I guess being able to
add mappings into the config would be nice e.g:

[mappings]
gecos = fullName

and have that config change the way that attributes are looked up

[jaqx0r]

Comment #1 originally posted by jaqx0r on 2008-08-11T01:01:26.000Z:

I like the long-term fix, that sounds good.

[jaqx0r]

Comment #2 originally posted by jaqx0r on 2013-01-16T10:24:40.000Z:

This issue was closed by revision 025036e49f82.