Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the explicit exclusion of query params #29

Merged

Conversation

MTeres
Copy link
Contributor

@MTeres MTeres commented Aug 23, 2019

A viable(maybe) solution to #9. But not sure about lookupCustomQueryValue, any suggestions?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MTeres for doing this, I really appreciate it. A few small comments, but otherwise it looks great. Please regenerate the docs in this PR again after the changes are done! Thanks

lib/process.js Outdated Show resolved Hide resolved
test/process/test.js Outdated Show resolved Hide resolved
@noahdietz noahdietz merged commit e0787df into google:master Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants