Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit setBufferSize to reduce glitches #654

Closed
philburk opened this issue Oct 2, 2019 · 5 comments
Closed

Limit setBufferSize to reduce glitches #654

philburk opened this issue Oct 2, 2019 · 5 comments
Assignees
@philburk
Labels
P1 high priority
Milestone
future

Comments

@philburk
Copy link
Collaborator

philburk commented Oct 2, 2019

In QuirksManager.cpp, based on device and version, prevent setBufferSize from going too low or too high.
@philburk philburk added this to the v1.3 milestone Oct 2, 2019
@philburk philburk self-assigned this Oct 2, 2019
@philburk
Copy link
Collaborator Author

Provide flag to enable workaround so Oboetester can still test underlyng API.
Provide stream to QuirksManager.
Add method to clip bufferSize.

@dturner
Copy link
Collaborator

dturner commented Nov 15, 2019

Solution for now: For all Samsung models we will not allow the buffer size to be <2 bursts. This is because at 1 burst you may get glitches caused by timing issues, and you won't receive any increase in underrun count so you may not be aware.

@dturner dturner modified the milestones: v1.3, future Nov 15, 2019
@philburk philburk added the P1 high priority label Nov 26, 2019
@paulorrfilho
Copy link

I think this is duplicated with #564

@paulorrfilho
Copy link

Currently I am working on porting my iOS app, DrumKnee, to Android but the constant glitches are a deal breaker. Hopefully someone will pick this one up shortly.

@philburk philburk mentioned this issue Dec 30, 2019
Merged
@smatt123 smatt123 mentioned this issue Jan 27, 2020
Closed
@philburk
Copy link
Collaborator Author

We have added a range limit to setBufferSize in the QuirksManager. This will not fix all glitches forever. But it will help. This task is finished so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philburk philburk

Labels
P1 high priority
Projects
None yet
Milestone
future
Development

No branches or pull requests
3 participants
@dturner @paulorrfilho @philburk