Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve continuous integration #54

Closed
jmichelp opened this issue Feb 25, 2020 · 4 comments · Fixed by #61
Closed

Improve continuous integration #54

jmichelp opened this issue Feb 25, 2020 · 4 comments · Fixed by #61
Assignees
Labels
enhancement New feature or request

Comments

@jmichelp
Copy link
Collaborator

Expected Behavior

All formatting, tests, and builds are run through Github workflows.

We should also use the Problem matchers wherever we can to have more automated actionable content in the Github PR review system.

Actual Behavior

Continuous integration runs on Travis-CI

Steps to Reproduce the Problem

N/A

Specifications

  • Version: N/A
  • Platform: N/A
@jmichelp jmichelp added the enhancement New feature or request label Feb 25, 2020
@jmichelp jmichelp self-assigned this Feb 25, 2020
@jmichelp
Copy link
Collaborator Author

PR #53 started duplicating a few tests from Travis-CI.

@jmichelp
Copy link
Collaborator Author

Now with PR #61 we have even better coverage than what Travis was doing, tests run in parallel instead of sequentially.

Leaving the bug open though because we're missing clippy due to libtock which triggers clippy errors. Will revisit when we'll be able to bump libtock-rs version.

Also leaving the travis-ci at the moment to ensure that both are catching errors on upcoming PRs and we can disable it once we're confident that everything runs fine.

@jmichelp jmichelp reopened this Mar 2, 2020
@gendx
Copy link
Collaborator

gendx commented Jun 22, 2020

Travis-CI has been broken in the last pull requests. Is it still useful or should we just get rid of it?

@jmichelp
Copy link
Collaborator Author

I removed it. We were only keeping it for a while to see if Github workflows were correctly on par with Travis-CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants