-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WHEEL file size mismatches for ortools-7.0.6546-cp36-cp36m-manylinux1_x86_64.whl #1218
Comments
Is it an issue for you ? As i said in the release note we provide a "manylinux1" package while in reality it is a "manylinux10" so we modify the package meta using sed which would explain the size diff. ref: or-tools/tools/docker/build-manylinux1.sh Lines 186 to 195 in 39f4470
|
I'm not sure I understand your comment about My project has a bunch of dependencies and
|
manylinux1 defined by PEP513 require So we used a manylinux2010 (PEP 571) proposal docker container to build a manylinux2010 package. Unfortunately pex seems to be a little bit agressive on its check, what you can do since pex seems to be a pure python lib is to hack the /usr/local/lib/python3.6/dist-packages/pex/vendor/_vendored/wheel/wheel/install.py", line 493 so pex don't care anymore of this.... note: official manylinux2010 docker container has just been released last week (yup 9 years late ;) ) |
Got it about libc and manylinux2010. It makes sense. In my build script I've added an exception for or-tools and it's repacked to make the hashes match, so that's not a big issue for me. I was just wondering if you want to patch |
For sure, i'm not against this idea, just need to see if i can take time to do it. |
I created a PR for this: #1222 |
Thanks.
I will let Corentin review it and merge it.
Laurent Perron | Operations Research | lperron@google.com | (33) 1 42 68 53
00
Le ven. 26 avr. 2019 à 19:47, Georgi Yanchev <notifications@github.com> a
écrit :
… I created a PR for this: #1222
<#1222>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1218 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACUPL3LFQYY6JGHZFSPQL4TPSM523ANCNFSM4HIO5OPQ>
.
|
Note that file WHEEL is of size 109, but in RECORD it's stated to be 112 bytes.
The text was updated successfully, but these errors were encountered: