Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on startup when you don't have a params file #32

Closed
Pontation opened this issue May 14, 2018 · 1 comment
Closed

Crash on startup when you don't have a params file #32

Pontation opened this issue May 14, 2018 · 1 comment

Comments

@Pontation
Copy link

Pontation commented May 14, 2018

Latest master (63f023d) crashes on startup when you don't have a params file because it then tries to save the file, which in turn triggers a notification to the UI which hasn't yet been initialized. Specifically
orbitmainwindow.cpp:44 calls OrbitApp::Init() which triggers the UI notification before it calls:

GOrbitApp->AddUiMessageCallback( [this]( const std::wstring & a_Message ) { this->OnReceiveMessage( a_Message ); } ); on line 59 to initialize the callback.

Since this callback has not been set, a std::bad_call exception is thrown from OrbitApp::SendToUiNow.

I built with VS2015 Release x64 and Qt 5.9.3.

@pierricgimmig
Copy link
Collaborator

Thanks for reporting this! Fixed in 34c9684. Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants