Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced conditional logic entry #70

Closed
priyald17 opened this issue Jul 30, 2013 · 0 comments
Closed

Enhanced conditional logic entry #70

priyald17 opened this issue Jul 30, 2013 · 0 comments
Assignees
@priyald17
Labels
Component-Server enhancement Experiments-Creation Priority-Medium
Milestone
CurrentSprint

Comments

@priyald17
Copy link
Contributor

User should be able to define conditional logic by:

  • Entering name of input on which the current input depends.
  • Getting a pull-down menu based on the type of that question.

Features:

  • User should be able to see what numbers correspond to. (E.g. if list item 3 in q1 is "pickles", then when defining a conditional in q2 depending on q1, the user should be able to see that 3 = pickles).

Difficulties:

  • Dynamic updating of a question's conditional menus when the question itself is updated.
  • Parenthesization.
@ghost ghost assigned priyald17 Jul 30, 2013
priyald17 added a commit that referenced this issue Jul 31, 2013
@priyald17
issue #70 - Added enhanced conditional logic menus. TODO: provide a w…
565b78a 
…ay to hide the visual entry menu. TODO: testing. TODO parenthesization. TODO dynamic updating based on whether an input is changed.
priyald17 added a commit that referenced this issue Aug 1, 2013
@priyald17
issue #70 - Put conditional entry menus in a disclosure panel. Also r…
8adb895 
…eplaced deprecated EventHandlers for all experiment creation disclosure panels with OpenHandlers and CloseHandlers.
priyald17 added a commit that referenced this issue Aug 2, 2013
@priyald17
issue #70 - Got the conditional text box and the conditional list box…
043775b 
… to update each other. TODO: better error handling. TODO: support for parens.
priyald17 added a commit that referenced this issue Aug 5, 2013
@priyald17
Merge pull request #106 from google/enhancedConditionalCreationCtd
89b427a 
[PARTIAL] issue #70  - enhanced conditional logic entry, ctd.
priyald17 added a commit that referenced this issue Aug 5, 2013
@priyald17
issue #70 - Fixed null pointer exception triggered when trying to fin…
90ae301 
…d inputs with a given conditional name.
priyald17 added a commit that referenced this issue Aug 6, 2013
@priyald17
issue #70 - Added parentheses logic to conditional entry.
f1c9bc1
priyald17 added a commit that referenced this issue Aug 6, 2013
@priyald17
Merge pull request #118 from google/enhancedConditionalCreationCtd
027715c 
[PARTIAL] issue #70 - Parentheses Logic
priyald17 added a commit that referenced this issue Aug 7, 2013
@priyald17
issue #70 - Dynamic updating of conditionals based on response type, …
0ec4a5f 
…list choice updates, likert steps update, and input deletion. TODO: update based on dragging and changing of input name.
priyald17 added a commit that referenced this issue Aug 7, 2013
@priyald17
issue #70 - conditionals now update based on input rename and input d…
90bf628 
…ragging (reordering)
priyald17 added a commit that referenced this issue Aug 7, 2013
@priyald17
issue #70 - added provisions to make sure conditional parentheses are…
ae1c1e6 
… balanced. Now, user cannot delete conditional expression from list if its parens are not balanced, and error message appears of user enters erroneous expression into conditional text box.
@priyald17 priyald17 reopened this Aug 12, 2013
priyald17 added a commit that referenced this issue Aug 12, 2013
@priyald17
issue #70 - Added some testing for conditional logic. Tested conditio…
abf26d6 
…nal regex and conditional text -> model/menu updates. TODO: more testing.
priyald17 added a commit that referenced this issue Aug 12, 2013
@priyald17
issue #70 - Updated conditional regex tests to include unbalanced par…
8806647 
…entheses.
priyald17 added a commit that referenced this issue Aug 12, 2013
@priyald17
Merge pull request #131 from google/conditionalLogicTesting
9e055ec 
issue #70 - Added some testing for conditional logic.
priyald17 added a commit that referenced this issue Aug 13, 2013
@priyald17
issue #70 - added conditional menu -> model/text update tests.
b5bf201
priyald17 added a commit that referenced this issue Aug 13, 2013
@priyald17
issue #70: Added some testing for interaction of conditional errors w…
ffc408b 
…ith form submission. Some refactoring.
priyald17 added a commit that referenced this issue Aug 13, 2013
@priyald17
issue #70 - Added testing for: 1) conditional rename when an input is…
dacc615 
… renamed, 2) conditional menu reconfig when input type, number likert steps, or list items are changed.
priyald17 added a commit that referenced this issue Aug 13, 2013
@priyald17
issue #70 -- Added testing for conditional updates based on input dra…
324088f 
…gging. Final conditional logic test.
priyald17 added a commit that referenced this issue Aug 16, 2013
@priyald17
issue #70: added some more validation to text entry in conditional te…
fdcc347 
…xt box based on actual input and predicate validity rather than just syntax validity.
priyald17 added a commit that referenced this issue Aug 16, 2013
@priyald17
Merge pull request #146 from google/visualNeatening
f0669a6 
issue #70 - Conditional text box extra validation
priyald17 added a commit that referenced this issue Aug 16, 2013
@priyald17
issue #70 - added some functionality such that invalid panels in menu…
4e3ad15 
… still result in valid conditional expression. Ensures text display expression does not start with an operator and that parens are balanced no matter which menu panels are invalid.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@priyald17 priyald17

Labels
Component-Server enhancement Experiments-Creation Priority-Medium
Projects
None yet
Milestone
CurrentSprint
Development

No branches or pull requests
1 participant
@priyald17