Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anchors and table of contents to period summary #22

Open
amdw opened this issue Mar 13, 2020 · 1 comment
Open

Add anchors and table of contents to period summary #22

amdw opened this issue Mar 13, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@amdw
Copy link
Collaborator

amdw commented Mar 13, 2020

Now the summary report has multiple panes, a table of contents and a set of internal anchor links would be very useful.

@amdw
Copy link
Collaborator Author

amdw commented Mar 18, 2020

Unfortunately it's not easy to make this work, because the elements to which we want to attach anchors are only available after an asynchronous data load. This is a well-known issue in Angular.

Even using router anchorScrolling doesn't seem to work for me.

https://angular.io/api/router/ExtraOptions#anchorScrolling

Even when I add a link and click it after the page has loaded, it doesn't work. I suspect the issue may be the following:

angular/angular#33240

The only thing I could make work was modifying the URL in the browser address bar to add the hash-fragment after the page has loaded, which is obviously useless.

There are some workarounds, but it might be better just to wait until Angular improves its capabilities in this area.

@amdw amdw added the enhancement New feature or request label Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant