Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cpik refuses to encode png file #28

Closed
ruuda opened this issue Aug 10, 2017 · 1 comment
Closed

Cpik refuses to encode png file #28

ruuda opened this issue Aug 10, 2017 · 1 comment

Comments

@ruuda
Copy link
Contributor

ruuda commented Aug 10, 2017

The attached image google-chrome fails to encode:

bin/cpik google-chrome.png 3.0 chrome.pik
Not a JPEG file: starts with 0x89 0x50

This is technically correct, it is a png file, and the first two bytes are the correct bytes for the png header. The file does have an alpha channel. If this is not supported, the tool should report that, rather than complaining about jpeg files, as the usage indicates that the input should be a png file.

@jan-wassenberg
Copy link
Member

Thanks, Ruud, for reporting this. I just successfully tested with this image, looks like we've fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants