Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep game version when switch from Instant to Installed #5

Open
megasoft78 opened this issue Apr 17, 2020 · 2 comments
Open

Keep game version when switch from Instant to Installed #5

megasoft78 opened this issue Apr 17, 2020 · 2 comments
Assignees

Comments

@megasoft78
Copy link

Hi,
I'd like to suggest a little improvement.
When I switch from Instant to Installed and vice-versa the game version remain the same.
It would be nice if the plugin keep the version for each one.
This is very useful because Instant version must always have a version number smaller than the current Installed one, so what I normally do is to keep them in a separate range.
For instance:
Instant Version 2.9.1.209 (Bundle Version Code 232)
Installed 2.9.2.5 (Bundle Version Code 1005)

This way I can update the Instant version without have to update the Installed one.

@thanwah
Copy link
Contributor

thanwah commented Apr 21, 2020

Thank you for the feature suggestion. Since some developers might not want or expect this behavior, I'm thinking perhaps that it should be opt-in and disabled by default?

I wonder if this should simply be 4 text boxes representing the 4 values of version and version code, as in your example. Or to take away some flexibility but make it more automatic, the installed version code could be determined by adding a constant to the instant version code. It sounds like your preference would be 4 text boxes?

@megasoft78
Copy link
Author

I think you are right. It can be confusing to change automatically the version and the version code when we switch between installed and instant.
Probably 4 text boxes is simpler but it need to be visible or people will go mad with that.
What if we have a checkbox (change version on switch) and 2 text boxes on the screen for switching between instant and installed and by default that checkbox is off?
The plugin should save internally version and version code based on the build type (instant and installed) and automatically populate based on the last save.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants