Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"(inline)" marker may be incorrect when -show or -hide filter is used #511

Open
aalexand opened this issue Feb 20, 2020 · 0 comments
Open
Labels
Priority: p2 Buganizer priority - P2 type: bug Buganizer type - Bug

Comments

@aalexand
Copy link
Collaborator

The inline flag may be inaccurate if 'show' or 'hide' filter is used. Those filters may filter out some of entries in the line array causing a remaining entry (which is physically inlined) to be the rightmost entry in the filtered array, and this heuristic will erroneously consider that line entry as not inlined.

Example:

$ go run pprof.go -top -symbolize=none -show=math.Abs internal/report/testdata/sample.cpu | grep math.Abs
   show=math.Abs
     110ms  6.25%  6.25%      110ms  6.25%  math.Abs
$ go run pprof.go -top -symbolize=none internal/report/testdata/sample.cpu | grep math.Abs
     0.11s  6.25% 87.50%      0.11s  6.25%  math.Abs (inline)
@Louis-Ye Louis-Ye added type: bug Buganizer type - Bug Priority: p2 Buganizer priority - P2 labels Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: p2 Buganizer priority - P2 type: bug Buganizer type - Bug
Projects
None yet
Development

No branches or pull requests

2 participants