Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.0: junit and easymock dependencies should only be required for tests #2019

Closed
onlyjob opened this issue Aug 26, 2016 · 2 comments
Closed

Comments

@onlyjob
Copy link

onlyjob commented Aug 26, 2016

As reported in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=835514
change of scope for junit and easymock resulted in practical problem downstream.

The following patch restores old behaviour:

--- a/java/core/pom.xml
+++ b/java/core/pom.xml
@@ -22,14 +22,17 @@
     <dependency>
       <groupId>junit</groupId>
       <artifactId>junit</artifactId>
+      <scope>test</scope>
     </dependency>
     <dependency>
       <groupId>org.easymock</groupId>
       <artifactId>easymock</artifactId>
+      <scope>test</scope>
     </dependency>
     <dependency>
       <groupId>org.easymock</groupId>
       <artifactId>easymockclassextension</artifactId>
+      <scope>test</scope>
     </dependency>
   </dependencies>
@xfxyjwf
Copy link
Contributor

xfxyjwf commented Aug 26, 2016

Could you submit the patch as a pull request?

@gerben-s
Copy link
Contributor

gerben-s commented Mar 9, 2017

Is this send as a PR?

haberman added a commit to haberman/protobuf that referenced this issue Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants