Migrate away from deprecated OSAtomic APIs. #4184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
1 similar comment
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
|
fyi - killed and restarted the macOS objc travis tests since yesterday's travis hiccups seem to have prevented this from getting tested. |
|
Thanks |
thomasvl
approved these changes
Jan 22, 2018
thomasvl
added a commit
to thomasvl/protobuf
that referenced
this pull request
Jan 23, 2018
Followup to protocolbuffers#4184, keep the import to not break any existing generated code that isn't regenerated when they update to the newer protobuf code.
thomasvl
added a commit
to thomasvl/protobuf
that referenced
this pull request
Jan 23, 2018
The generated code for enums needs atomics support, so generate the import instead of relying on it via transitive imports. This will make future changes to this likely likely to break generated code and runtime support are mixed. Followup to protocolbuffers#4184.
thomasvl
added a commit
to thomasvl/protobuf
that referenced
this pull request
Jan 25, 2018
Followup to protocolbuffers#4184, keep the import to not break any existing generated code that isn't regenerated when they update to the newer protobuf code.
thomasvl
added a commit
to thomasvl/protobuf
that referenced
this pull request
Jan 25, 2018
The generated code for enums needs atomics support, so generate the import instead of relying on it via transitive imports. This will make future changes to this likely likely to break generated code and runtime support are mixed. Followup to protocolbuffers#4184.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.