Spec needs to mention how AAD is formatted.

[insanum]

I didn't see any mention of the AAD format in the spec. I think it should be added.
Looking at the code I see the AAD is the entire PSP header plus any non-encrypted bytes (i.e., based on the crypt offset).

[hlrichardson]

The document also has a diagram showing that authenticated data includes all bytes from the beginning of the PSP header through the last payload byte, and encrypted data includes all bytes from crypt offset through the last payload byte. Would adding some text to say that the encryption method is AEAD where the associated data is from the first byte of the PSP header up to the crypt offset help clarify this?

[insanum]

Hey Lance. :-) Yes, what you describe should suffice.

[hlrichardson]

Spec has been updated as suggested. Thanks for the feedback!