Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This library does not seem to verify hostname #105

Closed
EasyAsABC123 opened this issue Apr 10, 2016 · 1 comment
Closed

This library does not seem to verify hostname #105

EasyAsABC123 opened this issue Apr 10, 2016 · 1 comment
Labels
bug php

Comments

@EasyAsABC123
Copy link

The fromJson function in Response does not validate the hostname attribute, which leaves this library vulnerable to bot attack.
@ismailbaskin ismailbaskin mentioned this issue Jun 11, 2016
Merged
@xthiago xthiago mentioned this issue Sep 23, 2016
Merged
@rowan-m
Copy link
Contributor

rowan-m commented Jul 31, 2018

I'm updating the v1.2 branch to include validation of the hostname and other attributes. Hopefully this should fix the issue.

@rowan-m rowan-m closed this as completed Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug php
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rowan-m @EasyAsABC123