Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s2 adds -std=c++11 uncoditonally #35

Closed
ObiWahn opened this issue May 28, 2018 · 0 comments · May be fixed by #37
Closed

s2 adds -std=c++11 uncoditonally #35

ObiWahn opened this issue May 28, 2018 · 0 comments · May be fixed by #37

Comments

@ObiWahn
Copy link

ObiWahn commented May 28, 2018

https://github.com/google/s2geometry/blame/master/CMakeLists.txt#L61

You should add this flag for clang/gcc to the private target definitions only. Or better use set( CMAKE_CXX_STANDAD 11) / comple features . It could look like: target_compile_features(s2 PRIVATE cxx_std_11). Please use something newer than cmake 2.8.x. You have Blaze internally so don't force people to use antique cmake versions.

@jmr jmr closed this as completed in 7abc82f Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant