Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove dependency on jcenter. #12

Merged
merged 1 commit into from
Apr 23, 2021
Merged

feat: Remove dependency on jcenter. #12

merged 1 commit into from
Apr 23, 2021

Conversation

arriolac
Copy link
Contributor

Remove jcenter repo. Currently still fails due to:

A problem occurred configuring root project 'secrets-plugin'.
> Could not resolve all artifacts for configuration ':classpath'.
   > Could not find org.jetbrains.trove4j:trove4j:20160824.
     Searched in the following locations:
       - https://dl.google.com/dl/android/maven2/org/jetbrains/trove4j/trove4j/20160824/trove4j-20160824.pom
       - https://repo.maven.apache.org/maven2/org/jetbrains/trove4j/trove4j/20160824/trove4j-20160824.pom
     Required by:
         project : > com.android.tools.build:gradle:4.1.1 > com.android.tools.build:builder:4.1.1 > com.android.tools:sdk-common:27.1.1

Possible solution:
 - Declare repository providing the artifact, see the documentation at https://docs.gradle.org/current/userguide/declaring_repositories.html

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 24, 2021
@AlanChiou
Copy link

AlanChiou commented Apr 23, 2021

@arriolac
You can rerun checks, because Jetbrains has published this library to MavenCentral.
https://youtrack.jetbrains.com/issue/IDEA-261387
https://mvnrepository.com/artifact/org.jetbrains.trove4j/trove4j/20160824

@arriolac
Copy link
Contributor Author

Thanks!

@arriolac arriolac marked this pull request as ready for review April 23, 2021 22:14
@arriolac arriolac merged commit 52eaeea into main Apr 23, 2021
@arriolac arriolac deleted the remove_jcenter branch April 23, 2021 22:14
github-actions bot pushed a commit that referenced this pull request Jun 9, 2021
# 1.0.0 (2021-06-09)

### Features

* Add support for build-variant properties. ([b85ff47](b85ff47))
* Add support for build-variant properties. ([#11](#11)) ([7afdf07](7afdf07))
* Adding support for providing a default properties file. ([#7](#7)) ([6982e8b](6982e8b))
* Don't throw if defaults provided. ([#8](#8)) ([123714b](123714b))
* Remove dependency on jcenter. ([#12](#12)) ([52eaeea](52eaeea))
@github-actions
Copy link

github-actions bot commented Jun 9, 2021

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Jun 9, 2021
# 1.0.0 (2021-06-09)

### Features

* Add support for build-variant properties. ([b85ff47](b85ff47))
* Add support for build-variant properties. ([#11](#11)) ([7afdf07](7afdf07))
* Adding support for providing a default properties file. ([#7](#7)) ([6982e8b](6982e8b))
* Don't throw if defaults provided. ([#8](#8)) ([123714b](123714b))
* Remove dependency on jcenter. ([#12](#12)) ([52eaeea](52eaeea))
@github-actions
Copy link

github-actions bot commented Jun 9, 2021

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to androiddevnotesforks/secrets-gradle-plugin that referenced this pull request Jul 25, 2021
# 1.0.0 (2021-07-25)

### Features

* Add support for build-variant properties. ([b85ff47](b85ff47))
* Add support for build-variant properties. ([google#11](https://github.com/androiddevnotesforks/secrets-gradle-plugin/issues/11)) ([7afdf07](7afdf07))
* Adding support for providing a default properties file. ([#7](#7)) ([6982e8b](6982e8b))
* Don't throw if defaults provided. ([google#8](https://github.com/androiddevnotesforks/secrets-gradle-plugin/issues/8)) ([123714b](123714b))
* Remove dependency on jcenter. ([google#12](https://github.com/androiddevnotesforks/secrets-gradle-plugin/issues/12)) ([52eaeea](52eaeea))
* Replace artifact ID with hyphens. ([google#21](https://github.com/androiddevnotesforks/secrets-gradle-plugin/issues/21)) ([f5ee607](f5ee607))
* Use new onVariants API ([google#26](https://github.com/androiddevnotesforks/secrets-gradle-plugin/issues/26)) ([adeabae](adeabae))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants