Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the coco.py, some doubts about the objects' relationships #8

Open
hawkwater opened this issue Oct 25, 2018 · 1 comment
Open

In the coco.py, some doubts about the objects' relationships #8

hawkwater opened this issue Oct 25, 2018 · 1 comment

Comments

@hawkwater
Copy link

hawkwater commented Oct 25, 2018

In the coco.py, line 337-348

if sx0 < ox0 and sx1 > ox1 and sy0 < oy0 and sy1 > oy1:
        p = 'surrounding'
elif sx0 > ox0 and sx1 < ox1 and sy0 > oy0 and sy1 < oy1:
        p = 'inside'
elif theta >= 3 * math.pi / 4 or theta <= -3 * math.pi / 4:
        p = 'left of'
elif -3 * math.pi / 4 <= theta < -math.pi / 4:
        p = 'above'
elif -math.pi / 4 <= theta < math.pi / 4:
        p = 'right of'
elif math.pi / 4 <= theta < 3 * math.pi / 4:
        p = 'below'

I have some doubts about the 'above' and 'below', i think they should be exchanged and the code is

elif -3 * math.pi / 4 <= theta < -math.pi / 4:
        p = 'below'
elif math.pi / 4 <= theta < 3 * math.pi / 4:
        p = 'above'
@BupyeongHealer
Copy link

@hawkwater I was doubt same as you.
However, Actually, the original code is right becasue of the prior relationship between objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants