Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address console error on settings page #59

Closed
bjackson27 opened this issue Jun 25, 2019 · 0 comments · Fixed by #64
Closed

Address console error on settings page #59

bjackson27 opened this issue Jun 25, 2019 · 0 comments · Fixed by #64
Labels
P1 Medium priority Type: Bug Something isn't working
Milestone

Comments

@bjackson27
Copy link

bjackson27 commented Jun 25, 2019

Looks like the tag searching code is search a null value. Probably not a functionality breaking bug, however worth fixing.

915f7eef0abfbc763726fc7f4ca173f2

The error occurs here:

This is a regression and likely broke when we changed how/when the tag detecting iframe is loaded.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

  • Fix console error on settings page while checking for existing analytics tag

Acceptance criteria

  • No console errors should show on the settings page.
@bjackson27 bjackson27 added the Type: Bug Something isn't working label Jun 25, 2019
@ThierryA ThierryA added this to the 1.0.0-beta.1.1 milestone Jun 26, 2019
@ThierryA ThierryA added the P1 Medium priority label Jun 26, 2019
@ThierryA ThierryA modified the milestones: 1.0.0-beta.1.0.1, Sprint 1 Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants