Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adminbar menu should show on homepage #61

Closed
bjackson27 opened this issue Jun 25, 2019 · 1 comment
Closed

Adminbar menu should show on homepage #61

bjackson27 opened this issue Jun 25, 2019 · 1 comment
Assignees
Labels
P1 Medium priority Type: Bug Something isn't working
Milestone

Comments

@bjackson27
Copy link

bjackson27 commented Jun 25, 2019

When viewing the site homepage, users should see the adminbar menu. clicking this will show them details for the hompage only (eg not the entire site). Currently in my testing, I do not see the Site Kit menu on the homepage.

This only applies if the homepage already has stats available in Search Console.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

  • Ensure admin bar menu shows as expected for single posts when on a staging or development environment mirroring real posts, and ensure the menu is shown for the correct single post.

Acceptance criteria

  • For the following tests, either:
    • make sure the posts you test with have actual search console data available
    • or temporarily comment out the logic to make the admin bar menu depend on search console data
  • Set up your homepage to show a list of posts.
  • Go to the homepage and ensure the admin bar menu does not show up (since it for now only shows for individual posts).
  • Set up your homepage to show a static page and also pick a page in the same section for your blog.
  • Go to the homepage and ensure the admin bar menu shows up (since the homepage now is an actual post).
  • Go to the blog page and ensure the admin bar menu shows up (since the blog page is now an actual post). It should show stats for that blog page, not for any of the posts listed.
  • Ensure the More Stats links in the admin bar lead to the dashbaord detail stats for the same page in the backend.
@bjackson27 bjackson27 added the Type: Bug Something isn't working label Jun 25, 2019
@ThierryA ThierryA added this to the 1.0.0-beta.1.1 milestone Jun 26, 2019
@ThierryA ThierryA added the P1 Medium priority label Jun 26, 2019
@ivankristianto
Copy link
Contributor

QA passed based on the acceptance criteria. Closing this issue as fixed.

@ThierryA ThierryA modified the milestones: 1.0.0-beta.1.0.1, Sprint 1 Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants