Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update definition of GA4 Reporting feature tour #7879

Closed
aaemnnosttv opened this issue Nov 16, 2023 · 8 comments
Closed

Update definition of GA4 Reporting feature tour #7879

aaemnnosttv opened this issue Nov 16, 2023 · 8 comments
Labels
P1 Medium priority Type: Enhancement Improvement of an existing feature

Comments

@aaemnnosttv
Copy link
Collaborator

aaemnnosttv commented Nov 16, 2023

Feature Description

The feature tour for ga4Reporting is currently implemented as an on-demand tour, but has a version partially defined which is only used for automatic tours. It currently references a version placeholder though which is incorrect, but also not hurting anything.

version: 'n.e.x.t', // Change this version to the actual version when GA4 reporting is released to 100% of users.

We can set the version in case the tour ever moves to be implemented as an automatic tour, although it isn't strictly needed for now.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The GA4 reporting tour version should be set to 1.103.0
  • Any leftover related TODO comments for feature tours should be cleaned up (example)

Implementation Brief

Test Coverage

  • No changes expected

QA Brief

  • The GA4 reporting feature tour should continue to be triggered as before

Changelog entry

  • Update version used for GA4 feature tour.
@aaemnnosttv aaemnnosttv self-assigned this Nov 16, 2023
@aaemnnosttv aaemnnosttv added P1 Medium priority Type: Enhancement Improvement of an existing feature QA: Eng Requires specialized QA by an engineer labels Nov 16, 2023
@aaemnnosttv aaemnnosttv removed their assignment Nov 16, 2023
@aaemnnosttv aaemnnosttv removed the QA: Eng Requires specialized QA by an engineer label Nov 16, 2023
@tofumatt tofumatt self-assigned this Nov 16, 2023
@tofumatt
Copy link
Collaborator

IB ✅

@tofumatt tofumatt removed their assignment Nov 16, 2023
@wpdarren wpdarren self-assigned this Nov 17, 2023
@wpdarren
Copy link
Collaborator

@aaemnnosttv I included 1.103.0 on the tester plugin under Force initial Site Kit plugin version but no tooltip tour was triggered. Since we've removed the GA4Reporting feature flag, I am unsure how I could test this. Any ideas? 🤔

@aaemnnosttv
Copy link
Collaborator Author

@wpdarren this issue doesn't change the way the tour works as it is still triggered on-demand as before. It essentially just cleans up a few references in our tour definitions. It should be testable in the same way as before.

@wpdarren
Copy link
Collaborator

wpdarren commented Nov 23, 2023

@techanvil thank you for your advice with this one. Since the banner is no longer appearing that triggers the GA4Reporting feature tour, I used the code you gave me but this didn't trigger the tour. I set up a TasteWP site, and linked it to oi.ie.

googlesitekit.data.dispatch('core/ui').setValue('showGA4ReportingTour', true);

Any other ideas on how I might be able to test this? 🤔

image

@techanvil
Copy link
Collaborator

Hi @wpdarren - a detail we didn't cover is the prior version requirement, this feature tour will only be shown when upgrading from a version prior to 1.103.0 (or when using the Tester plugin to set the "initial Site Kit plugin version" accordingly). If you haven't already, give that a try.

@techanvil techanvil removed their assignment Nov 23, 2023
@wpdarren
Copy link
Collaborator

@techanvil thank you. I did use the tester plugin for 1.103.0 but that didn't work. I will do some more digging into this tomorrow and see if I can get it to work with upgrading.

@techanvil
Copy link
Collaborator

Thanks @wpdarren - you should set the version to an earlier version than 1.103.0 though, so that could be worth checking again.

@wpdarren
Copy link
Collaborator

QA Update: ✅

Verified that the GA4 feature tour still functions.

ga4.mp4

@wpdarren wpdarren removed their assignment Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

5 participants