-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update definition of GA4 Reporting feature tour #7879
Comments
IB ✅ |
@aaemnnosttv I included |
@wpdarren this issue doesn't change the way the tour works as it is still triggered on-demand as before. It essentially just cleans up a few references in our tour definitions. It should be testable in the same way as before. |
@techanvil thank you for your advice with this one. Since the banner is no longer appearing that triggers the GA4Reporting feature tour, I used the code you gave me but this didn't trigger the tour. I set up a TasteWP site, and linked it to oi.ie.
Any other ideas on how I might be able to test this? 🤔 |
Hi @wpdarren - a detail we didn't cover is the prior version requirement, this feature tour will only be shown when upgrading from a version prior to 1.103.0 (or when using the Tester plugin to set the "initial Site Kit plugin version" accordingly). If you haven't already, give that a try. |
@techanvil thank you. I did use the tester plugin for 1.103.0 but that didn't work. I will do some more digging into this tomorrow and see if I can get it to work with upgrading. |
Thanks @wpdarren - you should set the version to an earlier version than 1.103.0 though, so that could be worth checking again. |
QA Update: ✅Verified that the GA4 feature tour still functions. ga4.mp4 |
Feature Description
The feature tour for
ga4Reporting
is currently implemented as an on-demand tour, but has aversion
partially defined which is only used for automatic tours. It currently references a version placeholder though which is incorrect, but also not hurting anything.site-kit-wp/assets/js/feature-tours/ga4-reporting.js
Line 46 in bfd82b9
We can set the version in case the tour ever moves to be implemented as an automatic tour, although it isn't strictly needed for now.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
1.103.0
TODO
comments for feature tours should be cleaned up (example)Implementation Brief
Test Coverage
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: