Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Post July 31st, 2024] Remove the conditionality for including Switzerland in the list of regions for the EU user consent policy. #8720

Closed
12 tasks done
techanvil opened this issue May 16, 2024 · 7 comments
Labels
P1 Medium priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature

Comments

@techanvil
Copy link
Collaborator

techanvil commented May 16, 2024

Feature Description

This shouldn't be merged until a release that's after July 31st, 2024.

Once July 31st, 2024 has passed, the EU user consent policy will apply to Switzerland and the conditionality for including it introduced via #8643 should be removed (i.e. the date / feature flag check).

See the PR for the issue, #8704, for code-level details. Any code relating to the change which is no longer needed should be removed.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Switzerland (country code CH) should always be included in the list of "consent mode regions" in Site Kit, without a feature flag or date condition.
  • The consentModeSwitzerland feature flag should be removed.

Implementation Brief

  • Remove the consentModeSwitzerland feature flag from feature-flags.json.
  • In includes/Core/Consent_Mode/Regions.php, add 'CH' to the array EU_USER_CONSENT_POLICY and remove the condition completely in get_regions:- this function should now simply return EU_USER_CONSENT_POLICY.
  • Update assets/js/components/consent-mode/ConfirmDisableConsentModeDialog.js, removing the two conditions on 'CH' being included in the list of regions. The copy for both the Ads connected and not connected states should mention Switzerland:
    • When the Ads module is not connected the subtitle copy should be: Disabling consent mode may affect your ability in the European Economic Area, the UK and Switzerland to:
    • When the Ads module is connected the subtitle copy should be: Disabling consent mode may affect your ability to track these in the European Economic Area, the UK and Switzerland:

Test Coverage

  • Remove use requirement of the feature flag in assets/js/components/consent-mode/ConfirmDisableConsentModeDialog.test.js, in the should display appropriate subtitle with Ads connected and Switzerland included in list of consent mode regions test.
  • Update the tests assets/js/components/consent-mode/ConfirmDisableConsentModeDialog.test.js. Only two tests should be required:
    • should display appropriate subtitle with Ads not connected
    • should display appropriate subtitle with Ads connected
    • Switzerland should always be included in the subtitle copy.
    • Also remove the requirement for the feature flag in these tests.
  • In tests/e2e/specs/front-end/consent-mode.test.js, remove the test includes Switzerland (CH) in the list of regions when the consentModeSwitzerland feature flag is enabled.

QA Brief

  • Test disabling consent mode with both the Ads module enabled and disabled:
    • When the Ads module is not connected the subtitle copy should be: Disabling consent mode may affect your ability in the European Economic Area, the UK and Switzerland to:
    • When the Ads module is connected the subtitle copy should be: Disabling consent mode may affect your ability to track these in the European Economic Area, the UK and Switzerland:
  • The consentModeSwitzerland feature flag should not appear in the list of feature flags in the tester plugin.

Changelog entry

  • Update Consent Mode to always include Switzerland in its list of relevant areas.
@techanvil techanvil added P1 Medium priority Type: Enhancement Improvement of an existing feature labels May 16, 2024
@tofumatt tofumatt assigned tofumatt and unassigned tofumatt May 28, 2024
@benbowler benbowler assigned benbowler and unassigned benbowler May 28, 2024
@tofumatt tofumatt self-assigned this May 28, 2024
@tofumatt
Copy link
Collaborator

IB ✅

@tofumatt tofumatt removed their assignment May 28, 2024
@tofumatt
Copy link
Collaborator

Moving this to the backlog, but since we don't have sprints/releases as far ahead as August, just leaving the title in here for now. Please don't work on this for awhile 😅

@eclarke1 eclarke1 added the Team S Issues for Squad 1 label May 29, 2024
@benbowler benbowler self-assigned this Jun 3, 2024
@benbowler benbowler removed their assignment Jun 3, 2024
@tofumatt
Copy link
Collaborator

tofumatt commented Jun 3, 2024

This shouldn't be merged until a release that's after July 31st, 2024. I've added a note to the issue, but it's not worth reviewing this in case it will have merge conflicts in a few months.

For now this can stay in CR, but it will might need a bit more time in execution to clear up potential merge conflicts that come up over the next few months 😅

@tofumatt
Copy link
Collaborator

tofumatt commented Jun 3, 2024

Actually, there's a sprint now for 133, which will be the issue this should be released in, so I've moved the issue there 🙂

@mohitwp mohitwp self-assigned this Jul 29, 2024
@mohitwp
Copy link
Collaborator

mohitwp commented Jul 31, 2024

QA Update ❌

@benbowler

  • Tested on dev environment.

Issue - consentModeSwitzerland feature flag is still showing on dev environment.

image

@tofumatt
Copy link
Collaborator

Indeed, the feature flag should be removed. That should have been added to the QA brief as well, so I've updated the QA brief and added a new PR to remove the feature flag. Thanks @mohitwp 👍🏻

@tofumatt tofumatt removed their assignment Jul 31, 2024
@mohitwp
Copy link
Collaborator

mohitwp commented Aug 6, 2024

QA Update ✅

  • Tested on dev environment.

  • Verified The consentModeSwitzerland feature flag is removed.

  • Verified disabling consent mode with both the Ads module enabled and disabled:

    -- When the Ads module is not connected the subtitle copy should be: Disabling consent mode may affect your ability in the European Economic Area, the UK and Switzerland to:
    --When the Ads module is connected the subtitle copy should be: Disabling consent mode may affect your ability to track these in the European Economic Area, the UK and Switzerland:
    Also, verified the consent mode functionality and GA events.

image

image

image

Disable CM when Ads module connected and

Recording.1259.mp4

Disable CM when Ads module is not connected

Recording.1260.mp4

Switzerland (country code CH) included in the list of "consent mode regions" in Site Kit, without a feature flag or date condition.

Recording.1261.mp4

@mohitwp mohitwp removed their assignment Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

7 participants