-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Post July 31st, 2024] Remove the conditionality for including Switzerland in the list of regions for the EU user consent policy. #8720
Comments
IB ✅ |
Moving this to the backlog, but since we don't have sprints/releases as far ahead as August, just leaving the title in here for now. Please don't work on this for awhile 😅 |
This shouldn't be merged until a release that's after July 31st, 2024. I've added a note to the issue, but it's not worth reviewing this in case it will have merge conflicts in a few months. For now this can stay in CR, but it will might need a bit more time in execution to clear up potential merge conflicts that come up over the next few months 😅 |
Actually, there's a sprint now for 133, which will be the issue this should be released in, so I've moved the issue there 🙂 |
QA Update ❌
Issue - |
Indeed, the feature flag should be removed. That should have been added to the QA brief as well, so I've updated the QA brief and added a new PR to remove the feature flag. Thanks @mohitwp 👍🏻 |
QA Update ✅
|
Feature Description
This shouldn't be merged until a release that's after July 31st, 2024.
Once July 31st, 2024 has passed, the EU user consent policy will apply to Switzerland and the conditionality for including it introduced via #8643 should be removed (i.e. the date / feature flag check).
See the PR for the issue, #8704, for code-level details. Any code relating to the change which is no longer needed should be removed.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
CH
) should always be included in the list of "consent mode regions" in Site Kit, without a feature flag or date condition.consentModeSwitzerland
feature flag should be removed.Implementation Brief
consentModeSwitzerland
feature flag fromfeature-flags.json
.includes/Core/Consent_Mode/Regions.php
, add'CH'
to the arrayEU_USER_CONSENT_POLICY
and remove the condition completely inget_regions
:- this function should now simply returnEU_USER_CONSENT_POLICY
.assets/js/components/consent-mode/ConfirmDisableConsentModeDialog.js
, removing the two conditions on'CH'
being included in the list of regions. The copy for both the Ads connected and not connected states should mention Switzerland:Disabling consent mode may affect your ability in the European Economic Area, the UK and Switzerland to:
Disabling consent mode may affect your ability to track these in the European Economic Area, the UK and Switzerland:
Test Coverage
assets/js/components/consent-mode/ConfirmDisableConsentModeDialog.test.js
, in theshould display appropriate subtitle with Ads connected and Switzerland included in list of consent mode regions
test.assets/js/components/consent-mode/ConfirmDisableConsentModeDialog.test.js
. Only two tests should be required:should display appropriate subtitle with Ads not connected
should display appropriate subtitle with Ads connected
tests/e2e/specs/front-end/consent-mode.test.js
, remove the testincludes Switzerland (CH) in the list of regions when the consentModeSwitzerland feature flag is enabled
.QA Brief
Disabling consent mode may affect your ability in the European Economic Area, the UK and Switzerland to:
Disabling consent mode may affect your ability to track these in the European Economic Area, the UK and Switzerland:
consentModeSwitzerland
feature flag should not appear in the list of feature flags in the tester plugin.Changelog entry
The text was updated successfully, but these errors were encountered: