Enhance compatibility with Docker locally for E2E #9183
Labels
P1
Medium priority
QA: Eng
Requires specialized QA by an engineer
Team S
Issues for Squad 1
Type: Infrastructure
Engineering infrastructure & tooling
Feature Description
Newer versions of Docker Desktop don't expose the default socket (
/var/run/docker.socket
) by defaultIf disabled, this will cause E2E test runs to fail without an obvious reason as it is expected to exist since E2E requires Docker.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
dockerode
to the latest version (currently4.0.2
), as it will properly find the socket by default including better support cross-platformsite-kit-wp/tests/e2e/config/wordpress-debug-log/index.js
Line 35 in 64b8643
Test Coverage
QA Brief
This can be tested a few ways
tests/e2e/bin/test-docker-connectivity
and giveDocker
a non-existent socket path, then run E2E as usualnpm run test:e2e
tests/e2e/bin/test-docker-connectivity
. You should see the error message and a non-successful error code.Changelog entry
The text was updated successfully, but these errors were encountered: