Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

> 100% #35

Closed
dantreble opened this issue Dec 16, 2014 · 9 comments
Closed

> 100% #35

dantreble opened this issue Dec 16, 2014 · 9 comments

Comments

@dantreble
Copy link

2/2 Uploads now, it has carried on past 100%. All the files appear to be there. I'm not sure how long it would go as I have Ctrl+C's it.

It was compiled using go 1.2 on ubuntu 14.04 LTS

dan@georgeiii:~$ skicka upload /srv/samba/photos/Pictures/2011/2011-01-11/ /Pictures/2011/2011-01-11/
skicka: Getting list of files to upload... Done. Starting upload.
974.62 MB / 563.64 MB [======================================] 172.91 % -3h59m0s

dan@georgeiii:~$ skicka upload /srv/samba/photos/Pictures/2011/ /Pictures/2011/
skicka: Getting list of files to upload... Done. Starting upload.
7.48 GB / 6.86 GB [==========================================] 109.05 % -6h9m26s

Other than that, it is awesome, thanks Matt.

@mmp
Copy link
Contributor

mmp commented Dec 17, 2014

Ugh; the underlying issue seems to be that when Drive returns a transient error (which happens not infrequently--e.g. 'you're issuing too many requests, slow down'), then the upload accounting still thinks that at least some of the file has been uploaded. It's not immediately obvious how best to fix this, but I'll think about it a bit. Also, + @gusennan.

Assuming my repro of this is hitting the same bug, your uploads definitely aren't done even though progress has crossed 100%; you should wait until skicka exists out on its own.

Will see what we can do about this!

@gusennan
Copy link
Contributor

Yes, interesting. This could happen with d/l too. Think an appropriate
fix would 1) subtract progress of failed file or 2) add to the total bytes
to be uploaded. Will take a look today.
2014/12/17 上午1:54 於 "Matt Pharr" notifications@github.com 寫道:

Ugh; the underlying issue seems to be that when Drive returns a transient
error (which happens not infrequently--e.g. 'you're issuing too many
requests, slow down'), then the upload accounting still thinks that at
least some of the file has been uploaded. It's not immediately obvious how
best to fix this, but I'll think about it a bit. Also, + @gusennan
https://github.com/gusennan.

Assuming my repro of this is hitting the same bug, your uploads definitely
aren't done even though progress has crossed 100%; you should wait until
skicka exists out on its own.

Will see what we can do about this!


Reply to this email directly or view it on GitHub
#35 (comment).

mmp added a commit that referenced this issue Dec 18, 2014
@gusennan
Copy link
Contributor

@dantreble If you have some time, would you mind pulling down the latest version of the code from here and testing to see if you can reproduce the error or if it's fixed as far as you can see? This merged code (#37) should have fixed it.

@gusennan
Copy link
Contributor

Ping @dantreble

@dantreble
Copy link
Author

Sorry @gusennan I have been waiting a long time for the previous transfer to complete

dan@georgeiii:~skicka upload /srv/samba/photos/Pictures/2012/ /Pictures/2012/ skicka: Getting list of files to upload... Done. Starting upload.
21.68 GB / 13.10 GB [===========================================================27.66 GB / 13.10 GB [=====================================] 211.20 % -144h33m23s27.66 GB / 13.10 GB [=====================================] 211.20 % -144h33m23s28.53 GB / 13.10 GB [======================================] 217.80 % -153h7m48s

I have the new version compiled and ready to test, I just want this transfer in the old one to complete :-)

@mmp
Copy link
Contributor

mmp commented Dec 29, 2014

FWIW, if you interrupt the in-progress upload, all files that finished uploading should be up in drive. However, up to 4 files may be in-progress, so if they're large files, you may want to wait. If it's mostly small files, you shouldn't lose much by interrupting and restarting.

@dantreble
Copy link
Author

Thanks Matt, good to know not much is lost in the interrupt case. The program seems incredibly resilient, I think the 1 year old has unplugged the router at least twice during the transfer!

It's finished. So I'll give the new one a go on a smaller set of files. Thanks!

28.69 GB / 13.10 GB [======================================] 219.07 % 284h46m38s
skicka: preparation time 1m 47s, sync time 285h 56m 6s
skicka: updated 720 Drive files, 0 local files
skicka: 0 B read from disk, 0 B written to disk
skicka: 11.33 GiB uploaded (11.54 kiB/s), 0 B downloaded (0 B/s)
skicka: 10.35 MiB peak memory used

@dantreble
Copy link
Author

Seems to be working perfectly now, I can't break it. Thank you!

@gusennan
Copy link
Contributor

Great to hear! Thank you for checking again.
2014/12/31 下午11:34 於 "Dan Treble" notifications@github.com 寫道:

Seems to be working perfectly now, I can't break it. Thank you!


Reply to this email directly or view it on GitHub
#35 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants