Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Files >1.6 GB fail to upload #12

Closed
agoode opened this issue Aug 31, 2014 · 6 comments
Closed

Files >1.6 GB fail to upload #12

agoode opened this issue Aug 31, 2014 · 6 comments

Comments

@agoode
Copy link
Contributor

agoode commented Aug 31, 2014

When I upload files >1.6GB, the upload runs for a long time, then fails with error *googleapi.Error googleapi: Error 401: Invalid Credentials, authError. The file exists in Drive as a 0-byte file.

This sounds like a server problem, but perhaps there is a workaround possible.

@mmp
Copy link
Contributor

mmp commented Sep 4, 2014

FWIW 401s generally correspond to the OAuth2 token expiring (as it does every hour, which is a bother), so that suggests that there is some code path that doesn't refresh the token and retry after a 401. I'm pretty sure all of the skicka code paths do handle this case, so I worry a little that there's something in the Drive API that doesn't handle this, and wherein if we refresh and retry, it will retry from scratch (and then timeout again).

Anyway, I'll see if I can reproduce (and then figure out where exactly it's failing...)

@agoode
Copy link
Contributor Author

agoode commented Sep 4, 2014

Ah. This probably means the token expires during the upload.

mmp pushed a commit that referenced this issue Oct 21, 2014
Still needs comments, lots of debugging code and FIXMEs are still 
in there.

There are currently some issues with refreshing OAuth2 tokens for
uploads that go over an hour.

This should fix issue #12 once it all works.
@ychuang-tw
Copy link

Hi. I have the same problem as described. The new version of skicka won't give an credential error msg. instead, it keeps uploading and going non-stop. Here's one example I'm trying to upload (7.92GB). It faced the same problem but keeps trying(?) to re-upload it (so it uploads more than 100% lol). Is there anyway to fix it? Thanks!

[root@alarm:/Volume/Stor/Torrent/Completed/Lucia.2014.BluRay.1080p.DTS.x264-CHD (8187.62 Mb)]# skicka upload Lucia.2014.BluRay.1080p.DTS.x264-CHD.mkv /Mov_UL/Lucia.2014.BluRay.1080p.DTS.x264-CHD
skicka: Getting list of files to upload... Done. Starting upload.
8.76 GB / 7.92 GB [============================================================================================================================] 110.71 % -12m37s

@mmp
Copy link
Contributor

mmp commented Dec 18, 2014

I think you're actually seeing issue #35, which was recently introduced. So it's presumably not actually done uploading when it hits 100%, but if you let it run until it exits on it own, it should get everything uploaded. (And we'll try to get #35 fixed soon...)

@mmp
Copy link
Contributor

mmp commented Jan 16, 2015

Resumable uploads for large files are tested and landed in e8f2736; if you can try it out and see if that fixes this for you, I'd be interested to hear.

@mmp
Copy link
Contributor

mmp commented Feb 26, 2015

Closing under the belief that this has been fixed with the resumable upload path.

@mmp mmp closed this as completed Feb 26, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants