Backend: Add Splunk as a backend provider #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
mveroone
force-pushed
the
Feat/splunk_backend_new
branch
3 times, most recently
from
cd2e3dd
to
00f3339
Compare
lvaylet
requested changes
May 10, 2023
|
FYI : commit is blocked by this for now : EDIT : I forced the commit with |
mveroone
force-pushed
the
Feat/splunk_backend_new
branch
from
68d506a
to
044eead
Compare
|
Hello, |
Signed-off-by: Maxime Véroone <maxime.veroone@decathlon.com>
mveroone
force-pushed
the
Feat/splunk_backend_new
branch
from
044eead
to
b5a8189
Compare
|
@lvaylet All your review points have been treated. Let me know if you have further remarks. |
|
@mveroone Sounds good to me now. Thanks for your hard work and patience! |
lvaylet
pushed a commit
that referenced
this pull request
Oct 20, 2023
* Backend: Add Splunk as a backend provider Signed-off-by: Maxime Véroone <maxime.veroone@decathlon.com> * WIP reveiw --------- Signed-off-by: Maxime Véroone <maxime.veroone@decathlon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty straightforward, even though it's somehow a new exercice for me to go that deep into the code.
The goal of that PR is to implement a new backend provider : Splunk.
Since their APIs are the same, it should work both with Splunk CLoud or Splunk Enterprise (on premises)
I've tested it against the later, but should be able to test with both if needs be.
All new features are documented in the right directories and tests & mocks were implemented.