Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

Add yapf to formatter #304

Open
oferb opened this issue Sep 14, 2018 · 0 comments
Open

Add yapf to formatter #304

oferb opened this issue Sep 14, 2018 · 0 comments
Labels

Comments

@oferb
Copy link
Contributor

oferb commented Sep 14, 2018

//tools:formatter currently relies on yapf being available on the user's system.
We should:

  1. Make an http_archive that will make bazel download it
  2. Add it to a BUILD file as a binary target, i.e py_binary
  3. Add it to runtime_deps of //tools:formatter, so that it's available for the tool to use, and make the tool call it.

It's similar to how buildifier and clang-format work with the formatter.

Yapf: https://github.com/google/yapf/releases

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant