Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create user configuration for attemptTimeout #228

Open
vanreece opened this issue Nov 2, 2021 · 2 comments
Open

Create user configuration for attemptTimeout #228

vanreece opened this issue Nov 2, 2021 · 2 comments

Comments

@vanreece
Copy link

vanreece commented Nov 2, 2021

Right now the attemptTimeout is just set to 10s, but it could be more useful to have this configurable in the json configuration.

I tried to find existing issues about this and couldn't find anything, so I'm opening a new issue for it.

@aomarks
Copy link
Member

aomarks commented Nov 2, 2021

Makes sense, thanks for filing. Do you have a benchmark that is expected to take more than 10 seconds?

@vanreece
Copy link
Author

vanreece commented Nov 2, 2021

Yeah, I'm using this as an end to end performance test for a heavy web app, and it turns out that fully loading before starting the benchmark takes long enough that I'm right on that threshold of 10s. Maybe not the intended use case for tachometer, but it works nicely for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants