Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gtfs/spec/reference): fix source of the inlining.svg image #448

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chtitux
Copy link

@chtitux chtitux commented May 1, 2024

Currently, on https://gtfs.org/schedule/reference/#shapestxt , the image for shape_dist_traveled is not working:
image

Moving the image where the other images are and using the same markdown image tag as the other ones should fix the issue.

CLA signed (@chtitux Github name matches)

@eliasmbd eliasmbd added GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule Change: Editorial Inconsequential changes to the specification such as link updates, grammatical errors, formatting. labels May 1, 2024
@eliasmbd
Copy link
Collaborator

eliasmbd commented May 1, 2024

@chtitux Thanks for posting this here! We appreciate your first contribution to GTFS and we are happy to have you with us. I am sure the community will get back to you in no time. We are also taking the time to review your PR at MobilityData.

While you wait, I would like to invite you to the MobilityData slack where you can join in realtime chat and engage with the rest of the GTFS community.

@eliasmbd eliasmbd added the Support: Needs Review Needs support to review proposal. label May 1, 2024
@Sergiodero
Copy link
Collaborator

Thanks @chtitux, after having a quick look I noticed that the reason this format is used to reference the image is to contain its size. With the suggested format the image takes up quite a bit of space, so I wouldn't suggest merging as is right now.

I think we might revisit this problem to propose a better, more standardized way of structuring assets in each folder across the repo, but it might take a few weeks for us to be able to take a stab at it.

In the meantime we'll manually make adjustments in gtfs.org.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Change: Editorial Inconsequential changes to the specification such as link updates, grammatical errors, formatting. GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule Support: Needs Review Needs support to review proposal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants