-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrying same page over and over in some cases #213
Comments
👀 I like breaking things. :) |
Seems to also get stuck downloading the same list of PR's over and over again:
Adding the same sort of logic to the pull_requests.go seemed to do the trick also. I don't know what kind of info might be missed because of this. Just treating the symptom basically 🙈 |
I have a similar but I don't know if the same problem when trying to fetch data for apache/airflow repository. I get the impression that the program goes into an infinite loop and can never get all the data. |
Yup seems to try getting the same page over and over blowing through the api limits repeatedly. It wasn’t until I added the check both places that it started working. I’ll open a PR with the changes I made |
I was trying this out on our github repo: https://github.com/rocketchat/rocket.chat and it got stuck on a single item in history. Added some verbose logs and it was getting stuck downloading the same page over and over again. I had to modify:
https://github.com/google/triage-party/blob/master/pkg/hubbub/timeline.go#L64-L66
to:
The one it actually got stuck on: RocketChat/Rocket.Chat#14278 not sure why 🤔
The text was updated successfully, but these errors were encountered: