Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent endless loop of loading same page #214

Merged
merged 2 commits into from
Oct 6, 2020

Conversation

geekgonecrazy
Copy link
Contributor

When loading up rocketchat/rocket.chat here on github it entered two different endless loops looking at the same page repeatedly. With the addition of these two checks it now loads the entire history successfully.

closes #213

@google-cla
Copy link

google-cla bot commented Sep 29, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@geekgonecrazy
Copy link
Contributor Author

@googlebot I signed it!

@mik-laj
Copy link
Contributor

mik-laj commented Sep 29, 2020

@geekgonecrazy Thanks! I'm starting to test this change.

Copy link
Contributor

@mik-laj mik-laj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It works.
Screenshot 2020-09-29 at 23 41 17
Before it stuck on 8.

@mik-laj
Copy link
Contributor

mik-laj commented Sep 29, 2020

Does this project have any CI? I cannot see any automatic tests running.

@geekgonecrazy
Copy link
Contributor Author

geekgonecrazy commented Sep 30, 2020

I'm not aware of one if so. Thanks for trying and confirming it worked for you 🙏

@geekgonecrazy geekgonecrazy changed the title Prevent loading same page Prevent endless loop of loading same page Sep 30, 2020
Copy link
Collaborator

@tstromberg tstromberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thank you!

@tstromberg tstromberg merged commit e37e213 into google:master Oct 6, 2020
@geekgonecrazy geekgonecrazy deleted the Prevent-loading-same-page branch January 1, 2021 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrying same page over and over in some cases
4 participants