Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-value dependency drags dep into truth's downstream #590

Open
cgruber opened this issue Jun 24, 2019 · 3 comments
Open

Auto-value dependency drags dep into truth's downstream #590

cgruber opened this issue Jun 24, 2019 · 3 comments
Labels
P3 not scheduled type=other Miscellaneous activities not covered by other type= labels

Comments

@cgruber
Copy link
Contributor

cgruber commented Jun 24, 2019

Auto-value annotations dependency is specified as a default (compile) dependency, which in maven-land means needed at compile time and runtime. This means that it leaks the version truth uses to any downstream project that fails to specify it, possibly conflicting with newer usages. Since Truth only needs auto-value to build itself, we should specify the dep as provided so it's not included in the transitive closure of Truth.

@cpovirk
Copy link
Member

cpovirk commented Jun 24, 2019

Our experience has been that provided makes things better for some people but worse for others: google/guava#2824

I could see adopting the jarjar approach you mention in #591, but ideally we'd leave the deps in place if the annotations continue to be present.

@cgruber
Copy link
Contributor Author

cgruber commented Jun 24, 2019

Ah, I see what you mean. I can rework this to remove the usages, given that they're totally vestigial at runtime. I can see the noise problem downstream, because of the warning behavior.

@raghsriniv raghsriniv added the P3 not scheduled label Jun 25, 2019
@nick-someone nick-someone added the type=other Miscellaneous activities not covered by other type= labels label Aug 19, 2019
@bryanstern
Copy link

Also running into this issue. Of course we can work around it, but would love to see the proposed fix ship.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 not scheduled type=other Miscellaneous activities not covered by other type= labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants