jobs_completed_total counter not covering all job completions

[hacktobeer]

The jobs_completed_total counter is not implemented to cover all possible ways a job can be set to completed and as such is incorrectly representing the total jobs completed.

turbinia/turbinia/task_manager.py

Line 69 in 67e7654

turbinia_jobs_completed_total = Gauge(

[hacktobeer]

It looks like it does cover all jobs. Some jobs error out because eg a target file to analyse can not be found. This is WAI....but I think we can improve the code to not throw a job error but let the job finish with a relevant message instead of just a job error.

[aarontp]

@hacktobeer Should we rename/update this issue to track the job error issue you mentioned then? Can you point to where this happens?

[hacktobeer]

Let's close this for now, as I changed the metrics type from Gauge to Counter, which should give a better representation of the different job metrics. I will test when the new release is deployed.