Skip to content

Commit

Permalink
Revert DiskBasedCache. (#366)
Browse files Browse the repository at this point in the history
The current implementation is not thread-safe, and making it thread-safe while
retaining an Asynchronous interface and allowing parallel reads would introduce
significant complexity. It is also limited to Android O+ which limits its value
at the moment.

For now, we can rely on either:

- AsyncRequestQueue's fallback support for regular Cache, which uses the blocking
  executor to perform reads. This is functional, but does make heavier use of the
  blocking executor than is ideal, and also does not currently permit parallel
  reads, although this could be added later as an improvement to DiskBasedCache.

- Cronet's own HTTP cache (although at the moment, we call disableCache(); we can
  make this configurable).

See #181
  • Loading branch information
jpd236 committed Sep 28, 2020
1 parent 7b0a311 commit a4954c6
Show file tree
Hide file tree
Showing 7 changed files with 599 additions and 1,769 deletions.
205 changes: 0 additions & 205 deletions src/main/java/com/android/volley/toolbox/CacheHeader.java

This file was deleted.

Loading

0 comments on commit a4954c6

Please sign in to comment.