Revert AsyncDiskBasedCache. #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation is not thread-safe, and making it thread-safe while retaining an Asynchronous interface and allowing parallel reads would introduce significant complexity. It is also limited to Android O+ which limits its value at the moment. For now, we can rely on either: - AsyncRequestQueue's fallback support for regular Cache, which uses the blocking executor to perform reads. This is functional, but does make heavier use of the blocking executor than is ideal, and also does not currently permit parallel reads, although this could be added later as an improvement to DiskBasedCache. - Cronet's own HTTP cache (although at the moment, we call disableCache(); we can make this configurable). See google#181
jbiral
approved these changes
Sep 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation is not thread-safe, and making it thread-safe while
retaining an Asynchronous interface and allowing parallel reads would introduce
significant complexity. It is also limited to Android O+ which limits its value
at the moment.
For now, we can rely on either:
AsyncRequestQueue's fallback support for regular Cache, which uses the blocking
executor to perform reads. This is functional, but does make heavier use of the
blocking executor than is ideal, and also does not currently permit parallel
reads, although this could be added later as an improvement to DiskBasedCache.
Cronet's own HTTP cache (although at the moment, we call disableCache(); we can
make this configurable).
See #181