Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

Changing a commit link during a proposal review does not update the commit hash #77

Closed
bluec0re opened this issue Nov 27, 2020 · 0 comments
Labels
bug Something isn't working p0 Issue with highest priority
Milestone

Comments

@bluec0re
Copy link
Contributor

Describe the bug
When a commit link is updated while a proposal is in review, the commit hash does not change.

To Reproduce
Steps to reproduce the behavior:

  1. User: Create a new proposal for an entry w/o commit link
  2. User: Enter a new commit link
  3. User: Request review
  4. Reviewer: Provide feedback
  5. User: Change commit link
  6. Reviewer & Admin: Approve and publish

Expected behavior
The detail view of the vulnerability shows the patch for the new commit link.

Observed behavior
The detail view of the vulnerability shows the patch of the previous hash.

Screenshots
https://www.vulncode-db.com/CVE-2018-7160

Additional context
Seems like the commit_hash column is not updated. Might happen in other situations as well

@bluec0re bluec0re added bug Something isn't working p0 Issue with highest priority labels Nov 27, 2020
@bluec0re bluec0re added this to the Gray Mercury milestone Nov 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working p0 Issue with highest priority
Projects
None yet
Development

No branches or pull requests

1 participant