Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "settings" screen #25

Closed
kamrik opened this issue Jun 9, 2016 · 3 comments
Closed

Add a "settings" screen #25

kamrik opened this issue Jun 9, 2016 · 3 comments

Comments

@kamrik
Copy link
Contributor

kamrik commented Jun 9, 2016

We need to be able to change a bunch of settings that are currently hard-coded.

Some settings are

  • Number of reps for each type of measurement
  • Delays between measurements
  • Thersholds for waht is condidered to be a "reasonable" reading
@BenjaminFair
Copy link
Contributor

How much of this should be in a global settings page versus in each one of the fragments? I think it would make sense to have settings for reps and delay in each individual fragment, especially since it doesn't apply to every test mode.

@kamrik
Copy link
Contributor Author

kamrik commented Jun 9, 2016

It's a matter of UI decision, when playing and experimenting it's better to have the setting hany on the same fragment. When running somewhat standardized test procedures it's more convenient to have all the setting in one place and to have the option to import and export settings files.

For simplicity I would prefer one settings page with all the settings there. We can put a button to access that page on fragments where it's especially handy.

@kamrik
Copy link
Contributor Author

kamrik commented Feb 14, 2017

Closing this. Settings page works well. More configurable parameters need to be added but those can be tracked in separate issues.

@kamrik kamrik closed this as completed Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants