Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for RsaKey for self-attestation #80

Closed
wants to merge 1 commit into from

Conversation

abahety
Copy link

@abahety abahety commented Mar 13, 2020

  • While testing in production, we found that windows devices with Hello support are generating self-attestation format with Rsa crypto and the current code is not supporting that
  • Raising this PR to expand the coverage and prevent failures

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@abahety
Copy link
Author

abahety commented Mar 13, 2020

@googlebot I signed it!

@abahety
Copy link
Author

abahety commented Mar 13, 2020

I am in process to get the corporate CLA get signed again and re-open this PR.

@abahety abahety closed this Mar 13, 2020
@abahety
Copy link
Author

abahety commented Mar 27, 2020

Reopening the pull request as we have signed a new CLA for eBay as a group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants