Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wire: unused provider error when only pointer to struct is used #29

Closed
zombiezen opened this issue Aug 14, 2018 · 0 comments
Closed

wire: unused provider error when only pointer to struct is used #29

zombiezen opened this issue Aug 14, 2018 · 0 comments
Assignees
@vangent

Comments

@zombiezen
Copy link
Collaborator

Repro case:

package main

import "github.com/google/go-cloud/wire"

type Foo struct{}

func inject() *Foo {
  wire.Build(Foo{})
  return nil
}

This produces the error:

foo.go:7:1: inject inject: unused provider "Foo"
wire: generate failed

I expect this to succeed.
vangent referenced this issue in vangent/go-cloud Aug 15, 2018
@vangent
One approach for issue #325
42c34fc
vangent referenced this issue in vangent/go-cloud Aug 15, 2018
@vangent
Another approach for issue #325.
eece7f8
vangent referenced this issue in vangent/go-cloud Aug 15, 2018
@vangent
Update Provider.Out to be a slice of provided types, and keep track
c52b93d 
of the provided concrete type in ProviderSet.providerMap, to more
clearly model named struct providers (which provide both the struct
type and a pointer to the struct type).

Fixes #325.
vangent referenced this issue in vangent/go-cloud Aug 16, 2018
@vangent
Update Provider.Out to be a slice of provided types, and keep track
df9dd6e 
of the provided concrete type in ProviderSet.providerMap, to more
clearly model named struct providers (which provide both the struct
type and a pointer to the struct type).

Fixes #325.
vangent referenced this issue in vangent/go-cloud Aug 16, 2018
@vangent
Update Provider.Out to be a slice of provided types, and keep track
0476bac 
of the provided concrete type in ProviderSet.providerMap, to more
clearly model named struct providers (which provide both the struct
type and a pointer to the struct type).

Fixes #325.
vangent referenced this issue in vangent/go-cloud Aug 16, 2018
@vangent
Update Provider.Out to be a slice of provided types, and keep track
19ac561 
of the provided concrete type in ProviderSet.providerMap, to more
clearly model named struct providers (which provide both the struct
type and a pointer to the struct type).

Fixes #325.
zombiezen referenced this issue in google/go-cloud Aug 16, 2018
@vangent @zombiezen
wire: update Provider.Out to be a slice of provided types, and keep t…
3a1b482 
…rack of the provided concrete type in ProviderSet.providerMap (#332)

Update Provider.Out to be a slice of provided types, and keep track
of the provided concrete type in ProviderSet.providerMap, to more
clearly model-named struct providers (which provide both the struct
type and a pointer to the struct type).

Fixes #325.
zombiezen referenced this issue Nov 28, 2018
@vangent @zombiezen
wire: update Provider.Out to be a slice of provided types, and keep t…
e93f331 
…rack of the provided concrete type in ProviderSet.providerMap (google/go-cloud#332)

Update Provider.Out to be a slice of provided types, and keep track
of the provided concrete type in ProviderSet.providerMap, to more
clearly model-named struct providers (which provide both the struct
type and a pointer to the struct type).

Fixes google/go-cloud#325.
@zombiezen zombiezen transferred this issue from google/go-cloud Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vangent vangent

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zombiezen @vangent