Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Pathways SIGTERMs from counting against backoffLimit #134

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Prevent Pathways SIGTERMs from counting against backoffLimit #134

wants to merge 1 commit into from

Conversation

SujeethJinesh
Copy link
Collaborator

Fixes / Features

  • Add podFailurePolicy so SIGTERMed Pathways workers do not count against the default backoffLimit (4).

Testing / Documentation

TODO

  • [ y ] Tests pass
  • [ y ] Appropriate changes to documentation are included in the PR

@SujeethJinesh SujeethJinesh mentioned this pull request Jul 8, 2024
Merged
shauryagup
shauryagup approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@shauryagup shauryagup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this check!

xpk.py
onExitCodes:
containerName: "pathways-worker"
operator: In # one of: In, NotIn
# TODO: verify this is the correct exit code
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this TODO now considering you have verified this exit code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shauryagup shauryagup shauryagup approved these changes

@Obliviour Obliviour Awaiting requested review from Obliviour Obliviour will be requested when the pull request is marked ready for review Obliviour is a code owner

@44past4 44past4 Awaiting requested review from 44past4 44past4 will be requested when the pull request is marked ready for review 44past4 is a code owner

@sharabiani sharabiani Awaiting requested review from sharabiani sharabiani will be requested when the pull request is marked ready for review sharabiani is a code owner

@pawloch00 pawloch00 Awaiting requested review from pawloch00 pawloch00 will be requested when the pull request is marked ready for review pawloch00 is a code owner

@BluValor BluValor Awaiting requested review from BluValor BluValor will be requested when the pull request is marked ready for review BluValor is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SujeethJinesh @shauryagup